Matthias Clasen [Mon, 16 Sep 2013 23:01:48 +0000 (19:01 -0400)]
Avoid a segfault when menus are re-shown under Wayland
The surface is destroyed when we hide a window, but
gdk_window_set_opaque_region can be called before the window is
shown again, so we need to ensure the surface exits.
https://bugzilla.gnome.org/show_bug.cgi?id=707328
Matthias Clasen [Mon, 16 Sep 2013 21:23:29 +0000 (17:23 -0400)]
Trivial formatting fixes
Matthias Clasen [Mon, 16 Sep 2013 20:13:07 +0000 (16:13 -0400)]
Allow theme to set close button position in headerbars
This allows GTK+ applications with headerbars to fit in
better in platforms that have window controls on the left.
To use this, set -GtkWindow-decoration-button-layout: 'close:'
in the theme.
https://bugzilla.gnome.org/show_bug.cgi?id=706708
Matthias Clasen [Mon, 16 Sep 2013 18:26:08 +0000 (14:26 -0400)]
Include CSD titlebar in focus chain
At least for header bars, there's often application controls
in this area, which should be included in the focus chain.
We make it so that the initial focus avoids the titlebar,
but tabbing around will eventually get there.
https://bugzilla.gnome.org/show_bug.cgi?id=708067
Yosef Or Boczko [Mon, 16 Sep 2013 18:15:26 +0000 (21:15 +0300)]
Updated Hebrew translation
Matthias Clasen [Mon, 16 Sep 2013 17:06:13 +0000 (13:06 -0400)]
Don't pass NULL to gdk_window_set_title
That is not allowed. This is fallout from a recent change
that makes GtkWindow listen for title changes in its
headerbar.
Matthias Clasen [Mon, 16 Sep 2013 17:02:57 +0000 (13:02 -0400)]
Update expected output for listbox tests
A recent commit changed the a11y role of listbox rows,
and should have really updated this test at the same time.
Benjamin Otte [Mon, 16 Sep 2013 13:40:54 +0000 (15:40 +0200)]
testsuite: Add deprecation guards for ATK deprecations
Benjamin Otte [Mon, 16 Sep 2013 13:36:07 +0000 (15:36 +0200)]
Revert "a11y: Remove AtkSelection implementation from combobox"
This reverts commit
7cecc8e524f9ac3825622e10f8a98f5e01ac4727.
It is impossible to use the selection object of the menu while it is
collapsed (collapsed menus deselect everything for a start), so even
though the original patch was correct, the followup issues are too big
to solve this quickly to a release.
https://bugzilla.gnome.org/show_bug.cgi?id=707786
Matthias Clasen [Mon, 16 Sep 2013 12:24:39 +0000 (08:24 -0400)]
Revert "Try Wayland before X11"
This reverts commit
04d6d622d52d544728563a83e76070748af9e6f4.
clutter and clutter-gtk are not quite ready to deal with this
change, so lets keep the order unchanged for 3.10 and revisit
next cycle.
https://bugzilla.gnome.org/show_bug.cgi?id=707704
Murray Cumming [Mon, 16 Sep 2013 12:10:52 +0000 (14:10 +0200)]
demos: Fix performance in GtkToolPalette demo.
gtk_icon_theme_list_icons() now gets so many icons that the demo
was unusable. Limit it to 10 per group (theme context).
Murray Cumming [Mon, 16 Sep 2013 12:04:24 +0000 (14:04 +0200)]
GtkWidget: Improve drag-leave and drag-data-received docs.
* gtk/gtkwidget.c: drag-leave signal: Document that it is called before
drag-drop.
drag-data-received signal: Document that it is up to the application
to know why the data was requested (e.g. drag motion or drop).
* demos/gtk-demo/toolpalette.c: interactive_canvas_drag_drop():
Do not transform the drop_item created in the drag-motion handler.
Instead caused drag-data-received to be called, remembering why,
and create a new item there.
interactive_canvas_drag_leave(): Remove the idle-handler hack,
now that we do not need to keep the drag-motion drop_item alive until
the drop.
I noticed that this patch was sitting in bug #605611 from 2009
though it had been approved. I do not remember much about why I
created it.
Kalev Lember [Sun, 15 Sep 2013 20:31:12 +0000 (22:31 +0200)]
listbox: Jump over insensitive rows with keynav
https://bugzilla.gnome.org/show_bug.cgi?id=708128
Gabor Kelemen [Mon, 16 Sep 2013 11:10:26 +0000 (13:10 +0200)]
Updated Hungarian properties translation
Carlos Garcia Campos [Tue, 18 Jun 2013 11:20:10 +0000 (13:20 +0200)]
gdkdisplay-x11: Do not pass a NULL source device to _gdk_display_device_grab_update
Pass the master device instead if the last slave is NULL. This is
unlikely to happen in most of the cases, but can happen when running
unit tests where there's no pointer interaction to update the last
slave.
https://bugzilla.gnome.org/show_bug.cgi?id=696756
Alexander Larsson [Mon, 16 Sep 2013 10:33:56 +0000 (12:33 +0200)]
Don't ever return BASELINE from gtk_widget_get_halign
This is the same behaviour as gtk_widget_get_valign, except
we have no gtk_wiget_get_halign_with_baseline, as baselines make
no sense for halign.
Without this some widgets (like e.g. GtkOverlay) crash if you accidentally
set a BASELINE halign.
Sébastien Wilmet [Sat, 14 Sep 2013 23:07:36 +0000 (01:07 +0200)]
Improve doc of gtk_text_buffer_paste_clipboard()
It didn't explain the behavior when there is a non-empty buffer
selection.
https://bugzilla.gnome.org/show_bug.cgi?id=339539
Sébastien Wilmet [Sat, 14 Sep 2013 22:28:33 +0000 (00:28 +0200)]
textbuffer: add unit tests for the clipboard
It tests gtk_text_buffer_paste_clipboard(),
gtk_text_buffer_copy_clipboard() and gtk_text_buffer_cut_clipboard() in
various situations, including when GtkTextTags are applied to the
selection.
The last test didn't pass.
https://bugzilla.gnome.org/show_bug.cgi?id=339539
Sébastien Wilmet [Wed, 10 Apr 2013 11:39:54 +0000 (13:39 +0200)]
textbuffer: fix selection replacement when pasting
It is more logical to first delete the selection and then pasting the
text. When the selection and the text contain tags, the new behavior is
more natural.
A segfault in paste_from_buffer() is also avoided. The segfault occurs when
the text to paste is deleted because it is the selection.
https://bugzilla.gnome.org/show_bug.cgi?id=339539
Ask H. Larsen [Sun, 15 Sep 2013 22:18:56 +0000 (00:18 +0200)]
Updated Danish translation of properties
Ask H. Larsen [Sun, 15 Sep 2013 22:17:22 +0000 (00:17 +0200)]
Updated Danish translation
Sébastien Wilmet [Tue, 10 Sep 2013 12:23:28 +0000 (14:23 +0200)]
Doc: small fixes in GtkTextView
Move GtkWrapMode from GtkTextTag to the GtkTextView section. The wrap
mode property is in the text view.
Links to the "mark-set" and "mark-deleted" signals.
Add a precision about gtk_text_buffer_get_iter_at_line().
Fix typo in gtk_text_tag_set_priority().
https://bugzilla.gnome.org/show_bug.cgi?id=708076
Changwoo Ryu [Sat, 14 Sep 2013 13:43:16 +0000 (22:43 +0900)]
Updated Korean translation
Andika Triwidada [Sat, 14 Sep 2013 13:18:34 +0000 (20:18 +0700)]
Updated Indonesian translation
Andika Triwidada [Sat, 14 Sep 2013 08:53:33 +0000 (15:53 +0700)]
Updated Indonesian translation
Alejandro Piñeiro [Thu, 12 Sep 2013 13:36:29 +0000 (15:36 +0200)]
GtkWindow: keep sync the title with own titlebar
Before this change, both titles were synced only if
gtk_window_set_title was called. Now both are synced
also calling gtk_header_bar_set_title
Alejandro Piñeiro [Thu, 12 Sep 2013 13:36:10 +0000 (15:36 +0200)]
a11y: Set proper role for GtkHeaderBar
https://bugzilla.gnome.org/show_bug.cgi?id=707981
Alejandro Piñeiro [Wed, 11 Sep 2013 14:50:29 +0000 (16:50 +0200)]
a11y: set ATK_ROLE_LIST_ITEM to GtkListBoxRow
https://bugzilla.gnome.org/show_bug.cgi?id=707915
Aurimas Černius [Thu, 12 Sep 2013 20:07:55 +0000 (23:07 +0300)]
Updated Lithuanian translation
Ihar Hrachyshka [Thu, 12 Sep 2013 17:14:11 +0000 (20:14 +0300)]
Updated Belarusian translation.
Gabor Kelemen [Thu, 12 Sep 2013 15:26:48 +0000 (17:26 +0200)]
Updated Hungarian translation
Rūdolfs Mazurs [Thu, 12 Sep 2013 11:01:16 +0000 (14:01 +0300)]
Updated Latvian translation
Alejandro Piñeiro [Wed, 11 Sep 2013 16:37:26 +0000 (18:37 +0200)]
a11y: Remove default description from GtkSwitch
https://bugzilla.gnome.org/show_bug.cgi?id=707926
Yuri Myasoedov [Thu, 12 Sep 2013 09:08:28 +0000 (13:08 +0400)]
Updated Russian translation
Pavol Klačanský [Wed, 11 Sep 2013 20:26:37 +0000 (22:26 +0200)]
Updated slovak translation
Matej Urbančič [Wed, 11 Sep 2013 19:11:15 +0000 (21:11 +0200)]
Updated Slovenian translation
Rico Tzschichholz [Wed, 11 Sep 2013 15:20:55 +0000 (17:20 +0200)]
Theppitak Karoonboonyanan [Wed, 11 Sep 2013 10:35:45 +0000 (17:35 +0700)]
Updated Thai translation.
Jiro Matsuzawa [Wed, 11 Sep 2013 10:09:39 +0000 (19:09 +0900)]
l10n: Update Japanese translation
Theppitak Karoonboonyanan [Wed, 11 Sep 2013 09:47:21 +0000 (16:47 +0700)]
Updated Thai translation.
Timo Jyrinki [Wed, 11 Sep 2013 07:04:12 +0000 (10:04 +0300)]
Finnish translation update
Timo Jyrinki [Wed, 11 Sep 2013 06:50:30 +0000 (09:50 +0300)]
Finnish translation update
Marek Černocký [Wed, 11 Sep 2013 06:22:27 +0000 (08:22 +0200)]
Updated Czech translation
Alejandro Piñeiro [Tue, 10 Sep 2013 17:29:56 +0000 (19:29 +0200)]
a11y: not using default name for switch
A proper name or label is required. In the same way, if the
widget is labelled, ATs uses to expose both the label and the
name, making the final output not really user-friendly.
https://bugzilla.gnome.org/show_bug.cgi?id=707872
Matthias Clasen [Wed, 11 Sep 2013 02:45:06 +0000 (22:45 -0400)]
Make logos in GtkAboutDialog bigger
When available, choose a size of up to 128 in GtkAboutDialog.
A 48x48 icon just looks too small in there.
Phil Clayton [Thu, 5 Sep 2013 00:08:41 +0000 (01:08 +0100)]
Add missing introspection annotations
https://bugzilla.gnome.org/show_bug.cgi?id=707519
Alexander Larsson [Tue, 10 Sep 2013 12:12:07 +0000 (14:12 +0200)]
listbox: Set activate_signal on listboxrow class
keyboard navigation didn't support activation since we moved
the keynav to the child row widgets. We fix this by adding a
activate signal handler for the row and setting
widget_class->activate_signal to it.
https://bugzilla.gnome.org/show_bug.cgi?id=707778
Lionel Landwerlin [Tue, 10 Sep 2013 10:20:28 +0000 (11:20 +0100)]
gdk: event: add get_window() method
https://bugzilla.gnome.org/show_bug.cgi?id=707844
Chun-wei Fan [Tue, 10 Sep 2013 07:51:23 +0000 (15:51 +0800)]
MSVC Builds: Fix gengir Projects
Like the install projects that were fixed few days ago, the gengir projects
did not have info on the intermediate and output directories as a result of
the split up of the property sheets. Fix this by including the appropriate
property sheet in the gtk-gengir property sheet so that we can avoid
confusing messages from Visual Studio on whether to reload the gengir
project as it was modified, at least on 2008.
Matej Urbančič [Mon, 9 Sep 2013 19:00:35 +0000 (21:00 +0200)]
Updated Slovenian translation
Matej Urbančič [Mon, 9 Sep 2013 18:36:26 +0000 (20:36 +0200)]
Updated Slovenian translation
A S Alam [Mon, 9 Sep 2013 18:27:33 +0000 (13:27 -0500)]
Punjabi Translation updated by Aman
Benjamin Otte [Mon, 9 Sep 2013 15:19:28 +0000 (17:19 +0200)]
Revert "pango: Handle case where pango_layout_get_text() returns NULL"
This reverts commit
70ac2b24c3d400c854d8a9e0937afa076f9dbe7f.
It turns out the correct fix is to make pango_layout_get_text() not
return NULL. This has been done, so we can drop this patch.
I won't bump the Pango dependency in configure.ac for this as I don't
consider the crash critical enough.
Benjamin Otte [Mon, 9 Sep 2013 14:50:55 +0000 (16:50 +0200)]
pango: Handle case where pango_layout_get_text() returns NULL
Fixes crashers with accessibility
https://bugzilla.gnome.org/show_bug.cgi?id=707659
Alexander Larsson [Mon, 9 Sep 2013 09:07:50 +0000 (11:07 +0200)]
Pixel cache: Add no-pixel-cache debug flag
This is useful for benchmarking comparisons, and to verify if bugs
happend with or without the pixel cache.
Christian Hergert [Fri, 6 Sep 2013 22:52:33 +0000 (15:52 -0700)]
textview: use pixelcache rendered area to inform invalidation region.
Use the pixelcache rendered area to inform what part of the cache should
be invalidated upon changes to the underlying textlayout.
By rendering the background to the pixelcache, we can avoid the need to
use RGBA content.
Also, we're using the pixel cache on the text windows bin_window (see
gtk_text_view_get_window) so we need to register the invalidation handler
on that, otherwise the region passed to the invalidate handler will get
clipped to the visible region.
https://bugzilla.gnome.org/show_bug.cgi?id=707244
Matthias Clasen [Mon, 9 Sep 2013 02:37:50 +0000 (22:37 -0400)]
Add a test for icons in menu models
testmenubutton now features an icon.
Matthias Clasen [Sun, 8 Sep 2013 20:39:49 +0000 (16:39 -0400)]
Add a testcase for custom levels in GtkLevelBar
This is related to https://bugzilla.gnome.org/show_bug.cgi?id=707695
Kjartan Maraas [Sun, 8 Sep 2013 17:40:51 +0000 (19:40 +0200)]
Updated Norwegian bokmål translation
Victor Ibragimov [Sun, 8 Sep 2013 12:21:16 +0000 (17:21 +0500)]
Tajik translation updated
Victor Ibragimov [Sun, 8 Sep 2013 12:18:11 +0000 (17:18 +0500)]
Tajik translation updated
Victor Ibragimov [Sun, 8 Sep 2013 12:06:57 +0000 (17:06 +0500)]
Tajik translation updated
Fran Diéguez [Sat, 7 Sep 2013 16:51:24 +0000 (18:51 +0200)]
Updated Galician translations
Christian Hergert [Fri, 6 Sep 2013 22:49:50 +0000 (15:49 -0700)]
pixelcache: add getter for extra width and height.
Christian Hergert [Fri, 6 Sep 2013 20:58:37 +0000 (13:58 -0700)]
textview: only set invalidate handler for text window.
Benjamin Otte [Fri, 6 Sep 2013 22:23:38 +0000 (00:23 +0200)]
reftests: I can't count in CSS
nth-child() is 1-indexed, not 0-indexed.
It doesn't matter for this test really, but better do it right to not confuse
poor developers who wonder why the first image is highlighted when nth-child(0)
clearly states "none".
Benjamin Otte [Fri, 6 Sep 2013 22:21:20 +0000 (00:21 +0200)]
reftests: Check that -gtk-image-effect is inherited
Claudio Saavedra [Fri, 6 Sep 2013 15:44:57 +0000 (18:44 +0300)]
gdk_pixbuf_get_from_source: only reuse surfaces with matching format
Otherwise the conversion functions will return rubbish.
https://bugzilla.gnome.org/show_bug.cgi?id=707445
Matthias Clasen [Fri, 6 Sep 2013 13:42:01 +0000 (09:42 -0400)]
Fix config dir <> data dir confusion
We added code to look for settings.ini in system config dirs,
and then proceeded to move it to /usr/share/gtk-3.0 :-(. So,
look in that location as well.
Chao-Hsiung Liao [Fri, 6 Sep 2013 08:26:34 +0000 (16:26 +0800)]
Updated Traditional Chinese translation(Hong Kong and Taiwan)
Rafael Ferreira [Fri, 6 Sep 2013 01:28:48 +0000 (22:28 -0300)]
Updated Brazilian Portuguese translationproofread by Enrico Nicoletto
Benjamin Otte [Fri, 6 Sep 2013 01:04:44 +0000 (03:04 +0200)]
reftests: Add test for just fixed Polari crasher
Benjamin Otte [Fri, 6 Sep 2013 01:01:37 +0000 (03:01 +0200)]
css: Change currentColor handling
We now pass NULL when the current color should be the default value of
the "color" property and we haven't looked up any value yet. This way we
don't need to look it up all the time and more importantly we can
resolve the default color, which is required because it's a
GtkCssColorValue and not a GtkCssRgbaValue.
Fixes assertions triggering at Polari startup.
Benjamin Otte [Fri, 6 Sep 2013 01:01:10 +0000 (03:01 +0200)]
cssimage: Remove unused variables
Matthias Clasen [Thu, 5 Sep 2013 22:50:23 +0000 (18:50 -0400)]
Don't use deprecated GSimpleActionGroup api
Instead, use the corresponding GActionMap api.
Matthias Clasen [Thu, 5 Sep 2013 22:45:16 +0000 (18:45 -0400)]
Don't call deprecated combobox api
gtk_combo_box_set_title is not needed anymore, since we
dropped the tearoff support.
Behdad Esfahbod [Thu, 5 Sep 2013 22:42:45 +0000 (18:42 -0400)]
[gdkcairo] Fix color premultiplication
https://bugzilla.gnome.org/show_bug.cgi?id=513812
Alexander Larsson [Thu, 5 Sep 2013 17:30:23 +0000 (19:30 +0200)]
Sync with changes in the cairo device-scale handling
The version of device scale that landed in upstream cairo
master already inherits the device scale in cairo_create_similar,
so no need to do that in gtk anymore.
Benjamin Otte [Thu, 5 Sep 2013 16:47:29 +0000 (18:47 +0200)]
reftests: Add a reftest for the cell renderer fix
The reftest is a bit flaky because it compares cell renderers with
GtkImage and therefor an icon view with a GtkBox, but it's the best I
can come up with.
https://bugzilla.gnome.org/show_bug.cgi?id=702423
Benjamin Otte [Thu, 5 Sep 2013 16:45:13 +0000 (18:45 +0200)]
cellrendererpixbuf: Don't eat states
Even when not following states, blacklist the states we don't follow
instead of whitelisting the ones we do. This way, we don't accidentally
eat new ones like the text direction flags.
Fixes a bug where text direction wasn't available when rendering stock
items.
https://bugzilla.gnome.org/show_bug.cgi?id=702423
Benjamin Otte [Thu, 5 Sep 2013 16:42:53 +0000 (18:42 +0200)]
cellrendererpixbuf: Follow state even when insensitive
Benjamin Otte [Thu, 5 Sep 2013 14:26:46 +0000 (16:26 +0200)]
cellrendererpixbuf: Always follow state
... not just in PRELIT | SELECTED.
Piotr Drąg [Thu, 5 Sep 2013 12:40:56 +0000 (14:40 +0200)]
Updated Polish translation
Daniel Mustieles [Thu, 5 Sep 2013 09:17:52 +0000 (11:17 +0200)]
Updated Spanish translation
Milo Casagrande [Thu, 5 Sep 2013 08:41:57 +0000 (10:41 +0200)]
[l10n] Updated Italian translation.
Chun-wei Fan [Thu, 5 Sep 2013 06:33:22 +0000 (14:33 +0800)]
Visual C++ Builds: Fix "install" Projects
Due to the split up of the property sheets, the install projects did not
have info on the Intermediate and Output Paths, which caused confusing
messages from Visual Studio to show up upon completing build+"install" and
closing Visual Studio on whether to reload the install project, at least on
Visual Studio 2008.
Also clean up the Visual Studio 2008 install project a bit.
Include the property sheet which defines these properties to fix this.
Matthias Clasen [Thu, 5 Sep 2013 00:59:56 +0000 (20:59 -0400)]
Trivial formatting fixes
Jiro Matsuzawa [Wed, 4 Sep 2013 16:39:16 +0000 (01:39 +0900)]
Fix a typo in an error message
https://bugzilla.gnome.org/show_bug.cgi?id=707488
Alexander Larsson [Wed, 4 Sep 2013 19:00:23 +0000 (21:00 +0200)]
GtkListBox: ref_sink new object in set_header and set_adjustment
These are taking ownership of the object in the hierarchy, so should
sink any floating refs to make it easy to use in C code.
Pavol Klačanský [Wed, 4 Sep 2013 19:00:20 +0000 (21:00 +0200)]
Updated slovak translation
Jasper St. Pierre [Wed, 4 Sep 2013 18:45:01 +0000 (14:45 -0400)]
gdkwindow-x11: Multiply opaque region rects by the window scale
This fixes rendering issues under HiDPI
Alexandre Franke [Wed, 4 Sep 2013 14:44:55 +0000 (16:44 +0200)]
Update French translation
Jasper St. Pierre [Tue, 3 Sep 2013 20:58:12 +0000 (16:58 -0400)]
gdkframeclockidle: Add explicit fallthrough markers
So people reading the code don't get confused.
Jasper St. Pierre [Tue, 3 Sep 2013 20:51:03 +0000 (16:51 -0400)]
accessible: Fix test runner
This was an obvious typo.
Jasper St. Pierre [Tue, 3 Sep 2013 20:47:21 +0000 (16:47 -0400)]
gtkwidget: Fix issues with baseline alignment comparison
Colin Walters [Tue, 3 Sep 2013 21:48:30 +0000 (17:48 -0400)]
build: Fix srcdir != builddir with wayland-client-protocol.h
In the gnome-ostree model builddir contains all generated files not in
git (unless the build system explicitly overrides that). Here the
wayland-client-protocol.h was in $(builddir)/wayland, so we need to
find it using our already extant -I$(top_builddir)/gdk, rather than
relying on same-directory lookup.
Changwoo Ryu [Tue, 3 Sep 2013 16:54:03 +0000 (01:54 +0900)]
Updated Korean translation
Giovanni Campagna [Tue, 3 Sep 2013 09:38:35 +0000 (11:38 +0200)]
wayland: set the wm_class on toplevel windows
Before mapping the window, set the title and class, to allow
application tracking by gnome-shell.
https://bugzilla.gnome.org/show_bug.cgi?id=707129
Giovanni Campagna [Tue, 3 Sep 2013 07:54:53 +0000 (09:54 +0200)]
gtk-shell: extend the protocol with shell capabilities
Add the concept of shell capabilities, which allow the compositor
to advertise support for the app menu and the global menubar,
which are then propagated as GdkSettings.
https://bugzilla.gnome.org/show_bug.cgi?id=707129
Giovanni Campagna [Fri, 30 Aug 2013 11:56:45 +0000 (13:56 +0200)]
wayland: restore support for the application menu
If the compositor supports the gtk-shell interface, use it to
export the application ID, dbus name and paths that can be used
for the application menu.
https://bugzilla.gnome.org/show_bug.cgi?id=707129